Brage Sekse Aarset

Results 177 comments of Brage Sekse Aarset

@JoseMoreville so you just uncommented those lines? [Link to your forked main.swift](https://github.com/JoseMoreville/active-win/blob/6160f9037f40629ee78f6bf753e5b286541f568d/Sources/ActiveWinCLI/main.swift#L21) Perhaps something is not right in those if statements. ```swift if !AXIsProcessTrustedWithOptions(["AXTrustedCheckOptionPrompt": true] as CFDictionary) { print("active-win requires...

> But along the way, I had an idea for an even better password validation system, where you can define the minimum, maximum length, the least amount of letters (upper...

I would suggest you wrap the `providers` optional parameter in an object. See this issue for more context about that https://github.com/validatorjs/validator.js/issues/1874 As you can see from the discussion there this...

> Do I have to make any changes @braaar cause it's been 27 days and this PR is still not merged after getting the approval. I don't intend to cause...

> In order to fix this issue, I referred to Joi, validated all the test cases, and separated them according to their validation. Also, I thought it unnecessary to have...

I don't want to patronize here, but I think you have a narrow interpretation of ISO8601, since you wrote this in #2003 > For example, 2009-222 is not a valid...

> I did my study on ISO8601, and I found out that it is unnecessary to cover the whole interpretation of ISO8601. Implementing it only for the Date in UTC...

> Now, I feel like we don't even need the strict mode. But, still, if we want to add it, we can cover the ordinal date, week with weekends and...

> Okay, @braaar. > > I will close this PR and create a new one to fix those issues. Also, can you tell me where I can discuss these new...

Could you be a little more specific? Which validators are you talking about? `IsPhoneNumber`? Others?