class-validator icon indicating copy to clipboard operation
class-validator copied to clipboard

feat: add option to validate decorators separately

Open mario-orlicky opened this issue 2 years ago • 2 comments

Description

Added a new validation option which forces to always validate a property even if the conditional validation results false. There is already an option named always which works with groups so I decided to name the new one ignoreValidation.

All tests pass except 2 tests related to JWT, but those tests fail also on develop branch so it was not caused by my changes - this could be caused by upgrading package versions regularly.

Checklist

  • [x] the pull request title describes what this PR does (not a vague title like Update index.md)
  • [x] the pull request targets the default branch of the repository (develop)
  • [x] the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • [x] tests are added for the changes I made (if any source code was modified)
  • [x] documentation added or updated
  • [x] I have run the project locally and verified that there are no errors

Fixes

fixes #318

mario-orlicky avatar Sep 16 '23 10:09 mario-orlicky

I don't know why a PR like this is not reviewed until now, I don't see the library maintainers willing to develop the library or add anything new, this library is so limited and good only for simple projects!!

tareksalem avatar Dec 09 '23 10:12 tareksalem

See my recent comment in #1721

braaar avatar Dec 15 '23 05:12 braaar