fix: MinDate & MaxDate constraint message unclear
Closes: #1869
Description
See #1869
Checklist
- [x] the pull request title describes what this PR does (not a vague title like
Update index.md) - [x] the pull request targets the default branch of the repository (
develop) - [x] the code follows the established code style of the repository
npm run prettier:checkpassesnpm run lint:checkpasses
- [x] tests are added for the changes I made (if any source code was modified)
- [x] documentation added or updated
- [x] I have run the project locally and verified that there are no errors
Fixes
fixes #[issue number], fixes #[issue number]
Let's see what the workflows say, @NoNameProvided ?
Let's see what the workflows say, @NoNameProvided ?
I think you need to approve again because I just merged develop to fix-1869 (it was outdated)
I did not get the reason why it says "First-time contributors need a maintainer to approve running workflows. Learn more.". You have already approved but workflow did not started..
I did not get the reason why it says "First-time contributors need a maintainer to approve running workflows. Learn more.". You have already approved but workflow did not started..
I'm not a maintainer. I'm on the triage team and can close issues and pull requests, but not merge code or approve workflow runs.
I did not get the reason why it says "First-time contributors need a maintainer to approve running workflows. Learn more.". You have already approved but workflow did not started..
I'm not a maintainer. I'm on the triage team and can close issues and pull requests, but not merge code or approve workflow runs.
Ah okay I see, so we'll wait until one maintainer approves 👍🏻
https://github.com/typestack/class-validator/blob/3f84de8f65fa34bb25f9c59d131ae1a694809a31/src/decorator/date/MinDate.ts#L9-L11
https://github.com/typestack/class-validator/blob/3f84de8f65fa34bb25f9c59d131ae1a694809a31/src/decorator/date/MaxDate.ts#L9-L11
It may be good to use isDate here to see whether passed prop is Date or Function like EmirBoyaci said above 😊
Hi @braaar since it has ~2 months without activity, can I ask you to ping maintainer? I do not know who is responsible but since then only dependabot is bumping package versions..