Brage Sekse Aarset
Brage Sekse Aarset
As long as we are using squash and merge I don't see any issue with the PR.
One way to achieve what you want today is to use the existing [validation groups](https://github.com/validatorjs/validator.js/pull/2009) combined with a function that, before validating, checks some property of the object to decide...
fixed by #910
> As mentioned before, my review won't help. But it all looks good to me! The woes of being an active contributor without write access 🥲
I agree! Let's do it!
I strongly prefer the options object, personally. It's easier to read and write when there are several options to choose from, and backwards compatibility is built in. I can help...
Solid plan! I think this will increase the quality and consistency of the code base considerably, and make it easier for contributors to make good quality contributions that are consistent...
Could it be desirable to add an option to this validator that lets you choose if you want to accept gmail's (seemingly) spec-breaking `+` ending?
Hey, @bassochette, things are happening on `develop`, so if you could clean up the diff this PR is hopefully close to getting merged :)
This is an upstream issue in validator.js, it seems