Christopher Hiller

Results 432 comments of Christopher Hiller

* **#2190** * **#2189** * **#2188** 👈 * `master` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @boneskull and the rest of your teammates...

@crossaaron the `wd` module is only used for tests on SauceLabs, which you aren't running locally, so not sure what the problem was there. at any rate, changes here should...

That's probably better addressed by Mocha. But we don't test the dot reporter in the browser (until I started messing with it, anyway), so not surprised I'd never heard of...

I can work around it for now by changing the value of `dot` in our tests. no rush.

Actually, this is fine if we make `--forbid-only` the default if the `CI` environment var is present.

Hi. `module.paths` is not part of the CJS standard. `module.paths` (and alternatives like the `NODE_PATH` envrionment variable) are undocumented and not "officially" supported. These are both in wide use, and...

Indeed, adding `module.paths` would increase Meteor's compatibility with Node modules. Don't know how difficult this would be to implement, or if there are other concerns about it.

FWIW, if a project like Mocha has the necessary resources, ensuring compatibility with other CommonJS implementations could be on the table. Mocha supports Node.js 0.10.x and greater across Windows and...

@apendua That's my assessment as well. But it's not fixed yet, and we aren't guaranteed future compatibility without adding and maintaining Meteor in our build matrix.

If you're looking to automate, I'd recommend just shipping your own types as a new package (e.g., `@wallabyjs/types` or something); we can easily deprecate the DT types once you publish....