mocaccino.js icon indicating copy to clipboard operation
mocaccino.js copied to clipboard

Published 20 hours ago • verified publisher icon mantoni

question: overwriting Base.symbols.dot

Open boneskull opened this issue 5 years ago • 5 comments

Here: https://github.com/mantoni/mocaccino.js/blob/master/lib/setup-browser.js#L14

and here: https://github.com/mantoni/mocaccino.js/blob/master/lib/setup-node.js#L12

Mocaccino overwrites Base.symbols.dot. Why?

boneskull avatar Mar 12 '19 17:03 boneskull

Because IE 11 somehow managed to show an empty dot report with the mocha default character. I’d be happy to remove this if there’s a better option.

mantoni avatar Mar 12 '19 19:03 mantoni

That's probably better addressed by Mocha. But we don't test the dot reporter in the browser (until I started messing with it, anyway), so not surprised I'd never heard of this.

boneskull avatar Mar 12 '19 20:03 boneskull

I tried to find the original issue but no luck, also not in Mochify. It’s been like this for a long time. It might have been a PhantomJS related issue that’s completely obsolete. I can run some tests tomorrow.

mantoni avatar Mar 12 '19 21:03 mantoni

I can work around it for now by changing the value of dot in our tests. no rush.

boneskull avatar Mar 12 '19 21:03 boneskull

I ran some checks and cannot find any issues anymore. Works fine in IE 11 and Edge without overriding the symbol. Feel free to remove.

mantoni avatar Mar 13 '19 11:03 mantoni