mocha icon indicating copy to clipboard operation
mocha copied to clipboard

Make --forbid-only (but not --forbid-pending) default in CI

Open ScottFreeCode opened this issue 8 years ago • 7 comments

Eventually let's make --forbid-only the default and use --no-forbid-only to disable it. Lots of CI will get safer for free!

(Pending, on the other hand, isn't so dangerous to begin with and has more long-term use-cases. It'll be inconsistent, but let's leave pending as-is.)

ScottFreeCode avatar Sep 29 '17 00:09 ScottFreeCode

Actually, this is fine if we make --forbid-only the default if the CI environment var is present.

boneskull avatar Sep 29 '17 06:09 boneskull

I agree with making --forbid-only the default on CI environment. Can I take this issue?

parksb avatar Jun 29 '19 08:06 parksb

@ParkSB Yes, you can.

outsideris avatar Jul 02 '19 15:07 outsideris

This issue hasn't had any recent activity, and I'm labeling it stale. Remove the label or comment or this issue will be closed in 14 days. Thanks for contributing to Mocha!

github-actions[bot] avatar Mar 28 '21 09:03 github-actions[bot]

This issue hasn't had any recent activity, and I'm labeling it stale. Remove the label or comment or this issue will be closed in 14 days. Thanks for contributing to Mocha!

github-actions[bot] avatar Jul 30 '21 00:07 github-actions[bot]

I'm in favor of this as a changed default for CI environments. It's better to have safety be opt-in IMO. This is what Vitest does and it's quite useful.

JoshuaKGoldberg avatar Jul 03 '24 13:07 JoshuaKGoldberg