Ben Straub
Ben Straub
just a warning sometimes the last little bit of coverage is the hardest part which is probably why we didn't write tests for it. Don't go too far down the...
@manciniedoardo and @bundfussr with the new roclet setup - are the functions we made in roxygen2.R still needed?
> > [@manciniedoardo](https://github.com/manciniedoardo) and [@bundfussr](https://github.com/bundfussr) with the new roclet setup - are the functions we made in roxygen2.R still needed? > > They are still used. but should it be...
> > I can take derive_vars_query() and derive_param_tte() [@bms63](https://github.com/bms63) [@manciniedoardo](https://github.com/manciniedoardo) > > Hi [@bms63](https://github.com/bms63) [@manciniedoardo](https://github.com/manciniedoardo) I need some time with derive_param_tte() as zap() is a bit complex for me. Meanwhile...
Just cleaning up the issue. Only two left. Who will take us to 100% test coverage!! @pharmaverse/admiral @pharmaverse/admiral_comm
We are moving roxygen2.R over to admiraldev. We achieved 100% yay!!
Thanks @MChiabudini for your feedback! :) @millerg23 do you mind taking a look at this please? I actually thought we took this into consideration when making this function.
Should we note this in the function documentation and recommended a way to address?
@millerg23 did we address this issue already or does this still need to be addressed?
@millerg23 just checking in if this still needs to be worked on for 1.2 release?