Ben Straub

Results 336 comments of Ben Straub

> I looked through the code before posting the issue. Unfortunately, `derive_param_qtc()` checks units via `admiraldev::assert_unit()` that in turn checks the `required_unit` argument using `admiraldev::assert_character_scalar()`, i.e. it expects a single...

@pharmaverse/admiral @pharmaverse/admiral_comm what do people think? The PR is already moving fast!! Thanks @yurovska !!

Sounds good! Do you mind making an issue in admiraldev for this update to `assert_unit()` We should make sure to note in the documentation that it has this flexibility as...

@kaz462 do you think you could add these in. I think they are super handy. The Stale Bot got us!!

Hi @kaz462 - do you have time to look over this guidance from Phuse - do we align to it? https://phuse.s3.eu-central-1.amazonaws.com/Deliverables/Safety+Analytics/WP-087+Recommended+Definition+of++Treatment-Emergent+Adverse+Events+in+Clinical+Trials+.pdf

Any takers for this @pharmaverse/admiral @pharmaverse/admiral_comm? The content is there - just making the diagram fit in our documentation would be very helpful. I really like [Lucid ](https://www.bing.com/aclk?ld=e82Xvq5f7PwlGPVhGwA1CntDVUCUxFhceA9gUcog6nf1oLW9d594a9p2cVVk-91Z-UGd7Pftye5AzeU3JCwkjXYbFoy-s9x4C_fCyj2Qv-jVS3NRZWNBbmX5KVpjNA10ASOR-bJ4p-CjHrqDc13i86TH5fkypJ9GrcmSOzrWnZHNo_7rOePE0EbjbuA0PA_0cSOL-hJA&u=aHR0cHMlM2ElMmYlMmZ3d3cubHVjaWRjaGFydC5jb20lMmZwYWdlcyUyZmxhbmRpbmclM2Z1dG1fc291cmNlJTNkYmluZyUyNnV0bV9tZWRpdW0lM2RjcGMlMjZ1dG1fY2FtcGFpZ24lM2RfY2hhcnRfZW5fdXNfbWl4ZWRfc2VhcmNoX2JyYW5kX2V4YWN0XyUyNmttX0NQQ19DYW1wYWlnbklkJTNkNjg3NjcwNTI2JTI2a21fQ1BDX0FkR3JvdXBJRCUzZDEyMzQ3NTI1Nzc2MTQ0MDklMjZrbV9DUENfS2V5d29yZCUzZGx1Y2lkY2hhcnQlMjZrbV9DUENfTWF0Y2hUeXBlJTNkZSUyNmttX0NQQ19FeHRlbnNpb25JRCUzZCU3YmV4dGVuc2lvbmlkJTdkJTI2a21fQ1BDX05ldHdvcmslM2RvJTI2a21fQ1BDX0FkUG9zaXRpb24lM2QlMjZrbV9DUENfQ3JlYXRpdmUlM2QlMjZrbV9DUENfVGFyZ2V0SUQlM2Rrd2QtNzcxNzIzMTU3NTAyMjMlM2Fsb2MtMTkwJTI2a21fQ1BDX0NvdW50cnklM2Q5NDU5MiUyNmttX0NQQ19EZXZpY2UlM2RjJTI2a21fQ1BDX3BsYWNlbWVudCUzZCUyNmttX0NQQ190YXJnZXQlM2QlMjZta3RfcXVlcnklM2RsdWNpZGNoYXJ0JTI2bXNjbGtpZCUzZDY1NjEyODdjN2ExNzFkOWZjZTU4NGY2MDdkMjYxZWM2&rlid=6561287c7a171d9fce584f607d261ec6&ntb=1)

not sure if we need a working group - @rossfarrugia also wanted us to review this paper https://phuse.s3.eu-central-1.amazonaws.com/Deliverables/Safety+Analytics/[WP-087+Recommended+Definition+of++Treatment-Emergent+Adverse+Events+in+Clinical+Trials+.pdf](https://phuse.s3.eu-central-1.amazonaws.com/Deliverables/Safety+Analytics/WP-087+Recommended+Definition+of++Treatment-Emergent+Adverse+Events+in+Clinical+Trials+.pdf) it is our oldest issue that we should resolve! maybe we can...

> The admiral functions don't attempt to preserve the sort order. Thus `restrict_derivation()` is not the only function where the sorting of the input and output may differ. I would...

> > @bundfussr Are you proposing a function that figures out how the data is sorted, stores that information and then a user can use it later on? > >...