Ben Straub comments

Results 336 comments of


                                            Ben Straub

Abstract report design

If disruption is minimal to users, then I am all for it! I was just thinking that we could follow the ggplot/ggplot2 path? Keep diffdf around and stable. I don't...

Bug: derive_summary_records() adds variables from dataset_ref

Might need to review other functions with similar behavior

Documentation: Add a small clarification in the vignette derive_basetype_records

same for this one @jimrothstein

Enhance test coverage for `get_vars_query()`, `assert_valid_queries()`, `validate_query()`, `basket_select()`

We have updated unit tests to cover all these functions. Going to close.

Closes #<2841> documentation derive vars dt clarify highest imputation definitions expand min dates example and add max dates example

> > Just for a sanity check - can you review the max and min date arguments in the tests and make sure we have some deeper coverage - the...

General Issue: Increase test coverage

FYI - Some of these could be very challenging. Please make sub-issues on ones that you would like to write tests for.

General Issue: Increase test coverage

Actually is anyone from @pharmaverse/admiral or @pharmaverse/admiral_comm willing to go through and make new issues for these missing test coverages that haven't already been created? Its a bit tedious work,...

General Issue: Increase test coverage

Closing as @manciniedoardo has started to do this

Bug: derive_param_qtc() expects QT and RR in "msec"

Could we allow the function to take in either ms or msec - @pharmaverse/admiral ?

Bug: derive_param_qtc() expects QT and RR in "msec"

Hi all, @pharmaverse/admiral We would like users to be able to use either msec or ms. I believe the assert function can handle this, but it might take a little...