Ben Straub
Ben Straub
> I would recommend not to add anything to admiral for this. we shouldn't add things already covered by tidyverse and also {metatools} provides https://pharmaverse.github.io/metatools/reference/sort_by_key.html which is a nice final...
Do any of the vignettes need to be updated as well? @Fanny-Gautier do you mind looking at this as well?
Can you check the vignettes as well? I believe some updates will be needed there as well. We try and keep them aligned as much as possible.
> > > Can you check the vignettes as well? I believe some updates will be needed there as well. We try and keep them aligned as much as possible....
The Links issue is being fixed in another PR FYI
``` derive_vars_dtm(dtc = AESTDTC, new_vars_prefix = "AST", highest_imputation="M", date_imputation = "first", min_dates = exprs(TRTSDT), max_dates = exprs(AEENDTCdate), precedent_dates = exprs(TRTSDT), ** flag_imputation="date" ) ``` So something like this?
I like min_dates_strict and max_dates_strict more than precendent_date. I feel like if a user is reading about these arguments then they probably are in this sort of territory?? So we...
@pharmaverse/admiral anyone have some bandwidth to work on this? Ideally like to get out for 1.4 !!!
@LaurentDassencourt not sure on your bandwidth and how deep into the matrix you want to go, but this one is a doozy if you want to look into it.
He @LaurentDassencourt I think we want users to have these abilities - it is a gap in our functions. However, the code base for these functions is already quite challenging...