Bjorn Lu

Results 767 comments of Bjorn Lu

I can reproduce this with the react template and moving the `index.html` to a folder. It's very similar to https://github.com/vitejs/vite/issues/4760. Likely the same core issue with Vite now allowing or...

This would be a breaking change, since `initCustomEvent` is used to support old browsers. An alternative is to check for the `CustomeEvent` constructor and conditionally use that, but that increases...

@imperator-maximus What browser are you using that doesn't work? [Caniuse](https://caniuse.com/mdn-api_customevent_initcustomevent) still shows that all evergreen browsers support it.

I don't think any tooling is using that (the `map`). I remember wanting to remove that in Svelte 4 and totally forgot 😅 The only breaking change would be if...

I remember having that same thought for Vite 4.0.1, made the change, and made a few people unhappy 😄 But since this is more internal stuff, and `injected` & `external`...

I think it is a good addition, though it would bear more maintenance work to make sure docs are updated in both places. Still would be better for the end-users...

> typedoc could generate json output and it is possible to convert that into the existing markdown format so the use experience remains the same. We had talked about this...

Related: https://github.com/vitejs/vite/issues/7163 and https://github.com/vitejs/vite/issues/2248

Hmm, you're right. I didn't think that esbuild could break the `\` at any position. I think some performance impact is expected, but unsure by how much. I wonder if...

/ecosystem-ci run Checking the ecosystem for this to see if it works. If it does, I think we can further improve the code since we're no longer dealing with quotes.