Bjorn Lu

Results 767 comments of Bjorn Lu

> Would making a new configuration option for the Vite config file fix this issue? Sorry for not getting back, this slipped through my notifications 😅 This would indeed be...

Dropping this off the milestone for now. We can revisit this in the next minor. Further context: https://github.com/vitejs/vite/pull/11854#issuecomment-1768841071

I also think this makes it hard to maintain even if it theoretically improves performance. If we do want to merge this, I think we need benchmarks to justify it.

Re-opening as fix is reverted in https://github.com/vitejs/vite/pull/13734

Besides nx which seems to take too long to test, the rest seems to match `main`, so merging this would be fine by me. I find the still incorrect import/export...

In the `import and export ordering` test, I have a comment that explained the desired execution order of `console.log`s. With this PR's new snapshot, if you run the logs in...

Putting this out of 5.0 milestone for now as this fix could be done in a patch in the future. We're trying to scope down the milestone to release on...

The schedule now is by the end of the month, so trying to finish up all of those in the milestone while having enough time for user testing.

It's still unclear how import attributes will go forward, and I'm leaning towards how the spec enforces it before we start implementing our custom handling. For example, the [spec mentions](https://github.com/tc39/proposal-import-attributes?tab=readme-ov-file#proposed-semantics-and-interoperability):...