Bjorn Lu

Results 767 comments of Bjorn Lu

Seems like this strategy works fine too. I think we can polish up the code a bit to no longer refer it as quotes.

Isn't using plain `__VITE_PRELOAD__` a valid module too? It's referring to a global `__VITE_PRELOAD__` variable. We also have a [fallback](https://github.com/vitejs/vite/blob/72343bebb755fedc4ebeb915fab3afcec924f820/packages/vite/src/node/plugins/importAnalysisBuild.ts#L535-L551) that replaces any existing `__VITE_PRELOAD__`, so it should not exist...

I'll queue this for the next minor then to be safe 👍

This seems to be much improved in Vite 4.5.0 now: ``` bjorn@Bjorns-MacBook-Pro vite-oom-repro % node --expose-gc test.js Loading progressively larger files and observing heap usage: Loading 10 MB file Loaded...

`build.ssrEmitAssets` needs to be enabled for this to work. I think this if fixed now, but if not, feel free to open a new issue with a repro.

> In some cases, for example -- force, node `fs.rmSync ` delete depsCacheDir (. vite/deps). If deps dir does not exist, all directories of .vite will be deleted, including deps_temp...

See https://vitejs.dev/config/server-options.html#server-https. [@vitejs/plugin-basic-ssl](https://github.com/vitejs/vite-plugin-basic-ssl) is required since Vite 3

It would be great if you can provide repro steps for the custom local certificate you mention, otherwise there isn't a way for us to debug and fix this.

Moving to the 5.0 milestone as we don't have a way to opt-out of this feature if someone needs to. Either a dedicated API, sharing with `build.rollupOptions.external`, ``, etc which...

> Would `?url` not work as a opt-out on a per-URL basis? We can't ask the user to update their links to opt-out. The links should stay as is. We'd...