Bjorn Lu comments

Results 767 comments of


                                            Bjorn Lu

'URL' named export breaks static file import in production build

The repro is using Vite 3, but I can confirm it happens in Vite 4 too. It's likely a bug in Rollup as it should internally alias the `URL` import...

'URL' named export breaks static file import in production build

Hmm actually looks like [Rollup is working fine](https://rollupjs.org/repl/?version=3.17.0&shareable=JTdCJTIyZXhhbXBsZSUyMiUzQW51bGwlMkMlMjJtb2R1bGVzJTIyJTNBJTVCJTdCJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMCU3QiUyMGltYWdlVXJsJTIwJTdEJTIwZnJvbSUyMCcuJTJGdXJsLXVzZS5qcyclM0IlNUNuaW1wb3J0JTIwJTdCJTIwVVJMJTIwJTdEJTIwZnJvbSUyMCcuJTJGdXJsLWV4cG9ydC5qcyclM0IlNUNuJTVDbmNvbnNvbGUubG9nKGltYWdlVXJsJTJDJTIwVVJMKSUyMiUyQyUyMmlzRW50cnklMjIlM0F0cnVlJTJDJTIybmFtZSUyMiUzQSUyMm1haW4uanMlMjIlN0QlMkMlN0IlMjJjb2RlJTIyJTNBJTIyZXhwb3J0JTIwY29uc3QlMjBVUkwlMjAlM0QlMjAnVVJMJTIwbmFtZWQlMjBleHBvcnQnJTNCJTIyJTJDJTIyaXNFbnRyeSUyMiUzQWZhbHNlJTJDJTIybmFtZSUyMiUzQSUyMnVybC1leHBvcnQuanMlMjIlN0QlMkMlN0IlMjJjb2RlJTIyJTNBJTIyZXhwb3J0JTIwY29uc3QlMjBpbWFnZVVybCUyMCUzRCUyMG5ldyUyMFVSTCgnLiUyRmltYWdlLnBuZyclMkMlMjBpbXBvcnQubWV0YS51cmwpJTIyJTJDJTIyaXNFbnRyeSUyMiUzQWZhbHNlJTJDJTIybmFtZSUyMiUzQSUyMnVybC11c2UuanMlMjIlN0QlNUQlMkMlMjJvcHRpb25zJTIyJTNBJTdCJTIyb3V0cHV0JTIyJTNBJTdCJTIyZm9ybWF0JTIyJTNBJTIyZXMlMjIlN0QlMkMlMjJ0cmVlc2hha2UlMjIlM0F0cnVlJTdEJTdE), perhaps Vite's dynamic usage of URL confuses Rollup, but I'm not sure how.

Blocked migration to SvelteKit 2 - Out of memory & explosion in compilation time

@hichemfantar Vite/Rollup needing large amounts of memory to build is not a memory leak. It requires keeping all modules and its representations in-memory, and that can require a large amount...

Some pages are displayed twice in search results (with and without `.html`)

The Vite site does enable Netlify's [Pretty URL feature](https://docs.netlify.com/site-deploys/post-processing/#post-processing-features), but it seems like it doesn't redirect to the prettier URL, it only enables "understanding" how to fallback for pretty URLs....

Support "worker" export condition when ssr.target is "webworker"

A similar feature request #7439

Allow to run tests in the main process

@matthewp suggested a workaround to use a file that imports all the test files so to node it looks like a single test file. It seems to work fine and...

Allow to run tests in the main process

By skipping `node:test`'s `run()` and importing the test files directly, I was able to test skipping the child process (can confirm that mutated globals are shared). Here's the result for...

Line limit from esbuild breaks vite production build

Didn't know that you can break strings this way. Seems like this should be fixable in Vite by relaxing this regex: https://github.com/vitejs/vite/blob/b7ddfae5f852c2948fab03e94751ce56f5f31ce0/packages/vite/src/node/plugins/importAnalysisBuild.ts#L40 Could also write a new unit test for...

fix(css): page reload was not happening with .css?raw

I sent a PR to Astro to fix this. It was incorrectly crawling into the dependencies to find CSS to inline. Skipping it fixes it.

Within a dev container using Docker 26, `vite dev` or `vite preview` cannot be accessed from the host

Could this be related to ipv4 and ipv6? The `host` in Vite is `"localhost"` by default, which internally in Node, it resolves to either `127.0.0.1` or `::1` depending on the...