Bjorn Lu

Results 767 comments of Bjorn Lu

I've updated the PR. Tried to update some of the newer places, and the tests seems to be passing, except ubuntu node14 (not sure if it's a fluke).

On top of this, if `beforeEach` provides a hint that it's currently a retry (or the current retry index), it would help to setup "debug features" for more verbose test...

_Putting my 2c on the issue._ ### What's slowing it down Through some profiling, we found that the amount of requests isn't an exact indicator of the slowness. You can...

I don't think the issue is within libraries (which we do support sideEffects today) as we already prebundle libraries. I think the bottleneck reported so far is in large codebases...

@jguddas I don't think that is quite related to this issue? Libraries are prebundled in dev so sideEffects doesn't really work, but it doesn't cause performance issues as it prebundles...

> That's beyond the point. Vite is using `process.env.NODE_ENV` internally. > [React](https://github.com/facebook/react/search?q=NODE_ENV) is using it. > Every single library you got... is using it. Vite is using it because it...

For `import.meta.env.DEV`, and alternative is to use https://github.com/benmccann/esm-env, which prevents double build size and works in non-Node environments too.

Closing as this PR brings in breaking changes.

I think instead of another option, it would be better if this can be solved through a Vite plugin by mapping virtual HTML files to separate 11ty HTML files. This...

Closing as I don't think this is possible without sacrificing startup/prebundling time. If there's a solution, feel free to send a PR directly. Thanks!