Bjorn Lu
Bjorn Lu
I believe this is fixed in https://github.com/vitejs/vite/pull/10996. Vite build will always default to prod by default, unless specifically changed with `NODE_ENV=development` in the env file, or in `process.env`.
Closing this for now based on the above comment
That one warning is a bug on my end. Should be fixed now (with no warnings)
Wouldn't this break for other Vite projects using Jest? Though I'm also fine with doubling-down to avoid the ESM shenanigans.
Maybe at the same time as going ESM only? We could also do a warning for Vite 5 at the mean time.
I'm checking this today to see what's the reason we have the code in the first place. https://github.com/vitejs/vite/pull/5197 adds it but it's not quite clear how to reproduce it today...
Dropping a related link that this feature would help https://github.com/rollup/rollup/issues/4294.
Yeah I think b is good enough. If they really need to wait for delayed modules to be loaded too, they can continue using the trick. The added benefit with...
Hmm yeah I think this could be a Vite bug. I remember `(`, `)`, `+`, etc being in the paths were already fixed, but maybe we weren't handling it right...
Seems like a bug in Svelte where the handlers are generated twice ([repl](https://svelte.dev/repl/31ddc37cfd684fd78310e6eb74b63e2c?version=3.55.0))