Ran Benita

Results 431 comments of Ran Benita

Thanks for the comments @oremanj! > AFAICT, the reason why hooks use this _Result object, instead of following `@contextmanager` style semantics where the inner result is directly sent or thrown...

So we've removed Python 2 support in master, and gearing up to a 1.0.0 release (which pytest 6.0.0 will hopefully depend on). So I'm trying to hookwrap my mind around...

Yes exactly. I'm not sure if we want to keep using the `pypa/gh-action-pypi-publish` action or switch to using `hatch publish`, I'll leave it to @RonnyPfannschmidt to decide.

Just saw this https://github.com/github/roadmap/issues/372 which is similar to planetuml, I might try it. Leaving their example here to see when it actually works :) ```mermaid graph TD; A-->B; A-->C; B-->D;...

Thanks for converting @nicoddemus! It does lose some details - namely it merges the nodes when it's better not, the placing of the `HookSpec` and the `...`. Maybe this can...

> Even hookwrapper argument could be dropped. If a hook is a generator than it is a wrapper. This is another obvious-in-retrospect idea. We should summon you more :) I...

The first point is covered by #280. For the second point I have a plan as well, will submit after the first PR is merged. As for point 3, it...

> I need to break out the _Result into it's own module, any preferences on a name? I was thinking _result.py ? I proposed this before in #227 so :+1:...

I have been working a bit on pytest performance lately, so let me know once you believe that the implementation is semantically correct, and I'll do some profiling on pytest...

Running pytest's test suite against this branch (+ switching to _c_multicall) gives two failures: Details ``` ================================================================================== FAILURES ================================================================================== ________________________________________________________________ TestTracebackCutting.test_traceback_argsetup ________________________________________________________________ self = , testdir = def test_traceback_argsetup(self, testdir):...