Ran Benita

Results 431 comments of Ran Benita

> Default will return all days of the month, all month of year. OK. Still it seems like they can share code, or at least be in the same file.

Can you show the exact way you invoke `pytest`?

If you split `'--engines_dir=C:\\The\\Argument\\We\\Passed\\To\\This\\Option'` into two separate arguments `'--engines_dir', 'C:\\The\\Argument\\We\\Passed\\To\\This\\Option'` does it still happen?

Given this directory tree ``` rec/ ├── link -> . ├── sub │   └── test_foo.py └── test_recursive.py ``` I tried 3 versions: --- Current master: ``` rec/test_recursive.py .[ 1%] rec/link/test_recursive.py...

Hi @aklajnert, thanks for the update, I think I see why you changed `_recurse` now. I'll clear some time to understand the collection code more so I can evaluate the...

I still haven't dug into the collection code but it occurs to me that the strategy of completely resolving all symlinks and deduplicating them can be problematic. Consider for example...

> I'm sorry that I couldn't work on it earlier. I've tried to rebase and work on it today but I've noticed that you did the refactor mentioned here in...

Hi @aklajnert, I obviously dropped the ball here and I don't even remember the exact details anymore, sorry about that. Looking at the tests, they do look good to me...

> Another hack I've been using is adding a deployment key to the repo + adding its private key as a secret. Then, in the workflows, add ssh-key to actions/checkout@v2...