pluggy icon indicating copy to clipboard operation
pluggy copied to clipboard

migrate to hatch + move importlib hacks to own module for typing

Open RonnyPfannschmidt opened this issue 3 years ago • 13 comments

RonnyPfannschmidt avatar Aug 03 '22 11:08 RonnyPfannschmidt

readthedocs seems to lack support for modern builds

RonnyPfannschmidt avatar Aug 03 '22 12:08 RonnyPfannschmidt

fixed the issues, will need to add some docs later today

RonnyPfannschmidt avatar Sep 23 '22 14:09 RonnyPfannschmidt

@pytest-dev/core this also serves as first example for going away from setuptools, please have a look

RonnyPfannschmidt avatar Sep 26 '22 08:09 RonnyPfannschmidt

will squash locally after approval

RonnyPfannschmidt avatar Sep 26 '22 11:09 RonnyPfannschmidt

Will reorder the commit content today to split the meaning

RonnyPfannschmidt avatar Sep 28 '22 04:09 RonnyPfannschmidt

@nicoddemus i'd appreciat another look over before merging the split commits

RonnyPfannschmidt avatar Oct 06 '22 13:10 RonnyPfannschmidt

@bluetech good catch, I think you mean these places?

https://github.com/pytest-dev/pluggy/blob/70fde45e41370327da008ff052e1da10aa714c0f/.github/workflows/main.yml#L145

https://github.com/pytest-dev/pluggy/blob/70fde45e41370327da008ff052e1da10aa714c0f/.github/workflows/main.yml#L112

https://github.com/pytest-dev/pluggy/blob/70fde45e41370327da008ff052e1da10aa714c0f/.github/workflows/main.yml#L148

nicoddemus avatar Oct 06 '22 19:10 nicoddemus

Yes exactly. I'm not sure if we want to keep using the pypa/gh-action-pypi-publish action or switch to using hatch publish, I'll leave it to @RonnyPfannschmidt to decide.

bluetech avatar Oct 06 '22 19:10 bluetech

There is an issue: hatchling itself depends on pluggy.

KOLANICH avatar Oct 27 '22 13:10 KOLANICH

I am against this as I prefer setuptools-scm, but I will not block the change.

ssbarnea avatar Jul 01 '23 14:07 ssbarnea

Hatch VCS uses Setuptools-scm

RonnyPfannschmidt avatar Jul 01 '23 14:07 RonnyPfannschmidt

This is currently indefinitely blocked as the dependency loop with hatchling needs a resolution

RonnyPfannschmidt avatar Jul 01 '23 14:07 RonnyPfannschmidt

Do I understand right that only migration to hatchling is blocked, but the rest of changes ("move importlib hacks to own module for typing") are not blocked.

KOLANICH avatar Jul 01 '23 16:07 KOLANICH