Ran Benita

> @bluetech that seems a very interesting feature. Are there any relevant runtime costs though? Good question. There is a performance overhead due to additional bounds checking when `_FORTIFY_SOURCE=3 `...

I understand what you mean now. But it's a bit hard for me to imagine how it will look. Do you mean, get rid of the intermediate AST layer, and...

For fun, I did a quick test for one expr type, action/action list: https://github.com/bluetech/libxkbcommon/commit/211ac59f57f8e33d3c676f47be53989af8bc36ec This does indeed make one place error early on invalid input - actions in symbols. But...

The array is just so simple and convenient :) My inclination is to stick with it unless someone asks to use some really high keycode or level.

There is a max of 10 errors: https://github.com/xkbcommon/libxkbcommon/blob/502e9e5bff3781cba09f3b33ec030522b549f4e5/src/compose/parser.c#L575 If I understand, you're thinking 1. If no valid sequences at all at the end, error. 2. If include fails, fail fast....

After reading the patch, I realize it's not very helpful for our purposes. The context buffer is a "scratch buffer" that is only allocated once and reused for all scratch...

The following should work: ``` include "%L" : "α" U03B1 # GREEK SMALL LETTER ALPHA ``` In XCompose, when there's an exact conflict, the latter wins. I just tested it...

I can't reproduce this, so something must be going on here. > xkbcommon: WARNING: /home/crater2150/.config/XCompose:2:41: this compose sequence already exists; overriding This looks good. > When pressing the compose key,...

Huh that's interesting. This is beyond the scope of libxkbcommon itself -- the library user decides how the keyboard devices map to `xkb_state` and `xkb_compose_state` objects. It's interesting that you...

(I've edited the title to the new question)