Ran Benita

> Is there any reason to be catching anything but Exception sub-types? pytest at least seems to rely on it. It has a couple of special control-flow BaseExceptions (`Skipped`, `Failed`)....

I kinda figured that such a change is a no-go for 1.26.x, but maybe for 2.x? Regarding pip, IIUC its default logging level without any verbose/quiet flags is INFO: https://github.com/pypa/pip/blob/b2b7aefe2f4a40fb34039adaab39897e80df687c/src/pip/_internal/utils/logging.py#L239...

Correction: reading that pip function further, it seems that for vendored libs like urllib3 they filter at WARNING: https://github.com/pypa/pip/blob/b2b7aefe2f4a40fb34039adaab39897e80df687c/src/pip/_internal/utils/logging.py#L253-L255 so if we change to INFO it *will* be filtered out.

- There are also `set_tunnel` and `tls_in_tls_required` (for `HTTPSConnection`), or are they intended to be encapsulated in one of the other methods? - You wrote `def getresponse(self) -> BaseHTTPResponse: ...`,...

I have some C code with benchmarks of different block sizes. I'm not sure if it really gives "true" results but you can try it anyway! The SIMD code assumes...

Yes, I agree. I thought there might be a way to do the runtime detection just once and store in a function pointer or something like that, but it's probably...

> Probably the Frame just should be made completely private to avoid confusion. It is only intended to be reused in implementation that don't want to use the high-level WebSocket...

Assuming Rust is good on its guarantees, the first thing to concentrate on is unsafe code. In tungstenite I believe there 2 places with unsafe (ignoring 3rd party libraries): in...

I was thinking that the `WebSocket` would change its state to CLOSING, upon which all future operations should fail-fast.

Sorry for the confusion - what I mean in the previous comment is what I think *should* happen in case one of the conditions occur. I think that when an...