Zeke Foppa
Zeke Foppa
Adding the `api-break` label because it seems like this requires SDK changes to provide the choice of compression? Not sure though, I didn't look to closely. Feel free to remove.
Nevermind, I read a bit more and it looks like we gracefully default to brotli.
Since this PR hasn't been updated in a while and is missing the client SDK pieces, closing this in favor of https://github.com/clockworklabs/SpacetimeDB/pull/3008.
What's the testing for this change? It looks like the test suite is failing - do existing tests need updating, and/or does it have new tests for the new behavior?
I'm not able to reproduce this issue. The `not null` check should be sufficient here 🤔 Can you share your `StdbModule.csproj` and `spacetime --version`?
Thanks @ScherrerMichael! It's the same code that's causing an error? What build command are you using?
@ScherrerMichael what does your `dotnet --info` say? I think we will probably just fix this with some more explicit null-casting, but it would be good to know why is happening...
Thank you! That all seems reasonable.. I guess we'll just update the quickstart and call it a day.
tl;dr @rekhoff I think the most straightforward fix is to just update the quickstart (and tutorial) with different null-handling, but I'd be interested to know if we have a way...
(we would also need to update `user.Name` to `user!.Name`)