SpacetimeDB icon indicating copy to clipboard operation
SpacetimeDB copied to clipboard

Add support for Gzip compression on server

Open lcodes opened this issue 1 year ago • 4 comments

Description of Changes

Removed the brotli dependency and replaced it with the flate2 library already being included.

API and ABI breaking changes

Changes the communications between the STDB server and its SDK clients, but opaque to users.

Expected complexity level and risk

  1. Straightforward change. Needs matching updates for the client repos.

Testing

Running the sdk test suite

lcodes avatar Jul 09 '24 16:07 lcodes

Note, I updated the PR title to reflect the decision to support Gzip in addition to Brotli compression.

joshua-spacetime avatar Jul 09 '24 18:07 joshua-spacetime

Adding the api-break label because it seems like this requires SDK changes to provide the choice of compression? Not sure though, I didn't look to closely. Feel free to remove.

bfops avatar Jul 15 '24 17:07 bfops

Nevermind, I read a bit more and it looks like we gracefully default to brotli.

bfops avatar Jul 15 '24 17:07 bfops

@lcodes this looks like it's ready although the sdk tests appear to be failing. Also if it's not too difficult, it would be really nice to add a test exercising gzip specifically.

joshua-spacetime avatar Jul 26 '24 23:07 joshua-spacetime

Had issues with getting sdk tests to pass on this branch, moved the impl back in parts to a new branch until tests pass again; moving the PR there https://github.com/clockworklabs/SpacetimeDB/pull/1642

lcodes avatar Aug 27 '24 18:08 lcodes