Ben McCann

Results 1460 comments of Ben McCann
trafficstars

We should also probably remove `sorcery` from `svelte-preprocess`: https://github.com/sveltejs/svelte-preprocess/issues/637

All dependencies have now been removed from `svelte-preprocess`: https://x.com/BenjaminMcCann/status/1810698991820321028 Now we'll need to either update `svelte-check` to use this new version (https://github.com/sveltejs/language-tools/pull/2401) or see if the dependency on it can...

here's a Svelte 5 upgrade PR that has lots of ignores related to this warning if you want to see some examples: https://github.com/immich-app/immich/pull/13738

I wonder if it should be something more like `\?(.*&)?(url|raw)` in case it is combined with another query parameter. Probably unlikely, but maybe safer?

Sorry this has sat for awhile. On second look, I'm wondering if this is something users would always want. E.g. `?url` might be helpful if you wanted to link to...

@ivanhofer if downgrade (i.e. `"sapper": "0.28.2",` in `package.json`) then I still see a red background. I tried with older versions besides that as well. Can you check the steps to...

No, I'm on Linux. We just checked in a big update to the CSS functionality. Can you try against `master`?

@ivanhofer I'm still getting a red background with 0.28.2 too, so I'm not sure this is a regression. In fact, in Sapper 0.28.0 and before most styles were included on...

@Rich-Harris this is something you mentioned wanting to support I believe. If you take a look at [the layout from this reproduction it has](https://github.com/ivanhofer/sapper-style-bug/blob/master/src/routes/_layout.svelte): ``` {#if false} {/if} ``` `InjectDevStyle.svelte`...

This does work if you change it to a dynamic import: ``` import Nav from '../components/Nav.svelte'; export let InjectDevStyle; if (false) { import('../components/InjectDevStyle.svelte').then(mod => { InjectDevStyle = mod.default; }); }...