Ben McCann

Results 1592 comments of Ben McCann

I'm not sure about your error, but I would recommend migrating to Svelte 4 first and not straight from 3 to 5

Thanks! We should definitely fix these. It looks like there's a number of merge conflicts unfortunately. Would you mind resolving the conflicts?

Can you drop the changes regenerating the docs? The setup is pretty finicky at the moment and I'd like to do that part myself after merging this

I've upgraded sharp in another PR to break things up and make it easier to review your new feature. Could you please rebase?

I think we should make this the default from the beginning. We can make it a major release since it's a breaking change. The option could be called something like...

thank you! closing this though as the linked issue has been resolved

So that I don't lose track of them: the `changesets` (https://github.com/changesets/changesets/pull/1417) and `json-schema-to-typescript` libraries are both waiting for this change

thank you so much!!

It looks to me like `config` is unused and perhaps should be removed while `prerender` should be `false` when no route is found unless it's a SPA fallback page

It is broken on 5.11.1, but I've sent a fix: https://github.com/bestguy/sveltestrap/pull/566