Ben McCann

Results 1460 comments of Ben McCann
trafficstars

I believe the standard way to do cache busting is to ask the bundler to add a hash to the filename. [I raised an issue in the template](https://github.com/sveltejs/sapper-template/issues/229) to add...

Perhaps this won't be required: https://github.com/facebook/docusaurus/pull/11020#issuecomment-2760582428 I've sent a PR: https://github.com/facebook/docusaurus/pull/11042

This sounds like the same issue as https://github.com/sveltejs/sapper/issues/1441

Yeah, I think I just added those all with `eslint --fix`, so I guess I missed that. https://github.com/sveltejs/svelte/blob/320ebd24d8857570b0c180752765fb1580590367/packages/svelte/src/compiler/validate-options.js#L1 Yeah, looks like it should be removed. But we might have to...

I think you could simplify `const cwd_value = typeof cwd_parent.cwd === 'function' ? cwd_parent.cwd() : undefined;` to just `const cwd_value = cwd_parent?.cwd();` I'm fine with adding Deno to the test...

> Is it even possible to inline srcset if it requires the execution of JS new URL(...).href? Yes > Shouldn't here the asset import be used instead? This isn't code...

If we can't hoist in the general case, I could still update `enhanced-img` to manually hoist these expressions since I know it is safe in that specific case. However, it...

This is solved with the latest release (numbers differ from above because I've made other changes to my site) 4.2.19 chunks - 39,785 bytes entry - 6,144 bytes nodes -...

We also need need this to get SvelteKit passing against the ecosystem CI since enhanced-img uses things like `TemplateNode`, `BaseDirective`, `Attribute`, and `SpreadAttribute` https://github.com/sveltejs/kit/blob/43544107269013e8b5160d268da25f1e003b6f6f/packages/enhanced-img/src/preprocessor.js#L44 https://github.com/sveltejs/kit/blob/43544107269013e8b5160d268da25f1e003b6f6f/packages/enhanced-img/src/preprocessor.js#L216

closing in favor of a PR against `main`: https://github.com/sveltejs/svelte/pull/14559