Ben McCann

Results 1519 comments of Ben McCann

PR welcome if you're able to track it down. I'm afraid I'm not going to have time to investigate it myself

There was a prior laravel issue. Please ensure you're using a version that includes that fix: https://github.com/JonasKruckenberg/imagetools/issues/396#issuecomment-1407819458

The URL gets built here: https://github.com/JonasKruckenberg/imagetools/blob/2da03b253eba04210f55f3abd08934105646bc0d/packages/vite/src/index.ts#L172 I often find it easiest to just go into node_modules and update the code there to experiment with changes. You could also pull in...

I'm not sure it's a breaking change. It sounds like a bug fix that users shouldn't notice. Worst case we could cut a new major though, so I'm open to...

No, I don't see an option for it there

If you're asking why copy-webpack-plugin needs it, perhaps it doesn't. I just assumed it would be desired since fast-glob was using it. But based off your comment on https://github.com/webpack-contrib/copy-webpack-plugin/issues/788, perhaps...

I'm closing this as it doesn't seem necessary

Please ping me when you send a PR to Vite and I will review it there

These are nice changes, but I wonder if they're working. When I visit https://github.com/Ocean-OS/svelte/tree/main I get a dead image

When this is ready we should test it against cspell to make sure we don't break it since it uses a negated ignore pattern and the behavior here will be...