Ben McCann

Results 1539 comments of Ben McCann

> vps Just FYI, this acronym is a bit confusing / overloaded because we also use it for `vite-plugin-svelte` > There is a big need for shared deploy adapters &...

SvelteKit has been updated so that all building occurs within a Vite plugin. Calling `vite build && vite build --ssr` seems too clunky so we're instead programatically invoking `vite` a...

SvelteKit has five build steps that must be run sequentially as each depends on the output of the step before it. One way to support this would be if Vite...

@aleclarson we need to run multiple builds, but they don't have to be defined via `vite.config.ts`. Other solutions like the addition of a sequential hook would work as well or...

You can set node to [inspect](https://medium.com/@paul_irish/debugging-node-js-nightlies-with-chrome-devtools-7c4a1b95ae27) in [the sample project](https://github.com/vitejs/vite/issues/2433#issuecomment-1114826695) by updating `package.json`: ``` "build": "node --inspect ./node_modules/@sveltejs/kit/svelte-kit.js build --verbose", ``` It was freezing my Chrome instance, so I had...

It looks like this stuff is being cached. I wonder if that's related to the memory leak? https://github.com/rollup/rollup/blob/275dc2fa34e1aaad37a29360570dc85b1ba019a6/src/ModuleLoader.ts#L274

Given that it seems like this issue is coming from Rollup, I would recommend anyone who wants to see this fixed try to see if you can create a very...

Yeah, I mentioned that option as well. It's a simpler user API, but likely to be a breaking change and harder for developers to use. I don't know which is...

I'll go ahead and close this since I agree with @bluwy that it's working as intended

Here's the logic as implemented, which looks at a few different variables to figure out if it's production: https://github.com/vitejs/vite/blob/60721ac53a1bf326d1cac097f23642faede234ff/packages/vite/src/node/config.ts#L450