acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor: path handling to use `std::filesystem`

Open AJPfleger opened this issue 1 year ago â€Ē 4 comments

Switch to using std::filesystem for path operations to modernize code and improve readability.

AJPfleger avatar Jun 18 '24 12:06 AJPfleger

📊: Physics performance monitoring for bb70544dc092c51d78a24147d30daff878a6adbf

Full contents

physmon summary

github-actions[bot] avatar Jun 18 '24 12:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.31%. Comparing base (eb8848f) to head (bd50b02). Report is 4 commits behind head on main.

Files Patch % Lines
Core/src/Visualization/GeometryView3D.cpp 0.00% 1 Missing and 5 partials :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3308   +/-   ##
=======================================
  Coverage   47.31%   47.31%           
=======================================
  Files         512      512           
  Lines       30440    30440           
  Branches    14795    14796    +1     
=======================================
  Hits        14403    14403           
+ Misses       5404     5403    -1     
- Partials    10633    10634    +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 18 '24 13:06 codecov[bot]

Hmm I wonder: Do we need joinPaths at all? Or can't we just switch wo working completely with std::filesystem::path objects here? and only use the / operator?

Same with getWorkingDirectory, I could imagine to just use the native function instead of implementing it through std::filesystem.

benjaminhuth avatar Jun 19 '24 11:06 benjaminhuth

sonarcloud: "Use std::format instead of concatenating pieces manually."

compiler: āžž;ÂīāžŽāšķ ۝ āžŽāšķāž―

AJPfleger avatar Sep 03 '24 13:09 AJPfleger

:white_check_mark: Athena integration test results [74d9aa24653027858659e28f3e6f0275cf799d6c]

:white_check_mark: All tests successful

status job report
:green_circle: report_pull_request
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco
:green_circle: test_ActsDumpGeometryIdentifiers
:green_circle: test_ActsCheckObjectCountsCachedWorkflow
:green_circle: test_ActsCheckObjectCountsWorkflow
:green_circle: test_ActsEFTrackFit
:green_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsWorkflowHeavyIons
:green_circle: test_ActsWorkflowFastTracking
:green_circle: test_ActsWorkflowCached
:green_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:green_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:green_circle: run_workflow_tests_run4_mc
:green_circle: run_workflow_tests_run2_mc
:green_circle: run_workflow_tests_run2_data
:green_circle: run_workflow_tests_run3_mc
:green_circle: run_workflow_tests_run3_data
:green_circle: run_unit_tests

acts-project-service avatar Sep 09 '24 18:09 acts-project-service