Since the GSF is not yet fully functional, it is put in the namespace Acts::Experimental.

Also adds some hints in the documentation, that components in this namespace are not yet production read, and also not part of the public API (I think that is reasonable, since clients should not rely on experimental code).

However, since this would be a new rule, this change is breaking.

Oct 20 '22 11:10 benjaminhuth

Codecov Report

Merging #1609 (f603349) into main (1d7e9b2) will decrease coverage by 0.02%. The diff coverage is 0.00%.

:exclamation: Current head f603349 differs from pull request most recent head d18177a. Consider uploading reports for the commit d18177a to get more accurate results

@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
- Coverage   48.66%   48.63%   -0.03%     
==========================================
  Files         381      381              
  Lines       20776    20786      +10     
  Branches     9517     9519       +2     
==========================================
  Hits        10110    10110              
- Misses       4095     4105      +10     
  Partials     6571     6571

Impacted Files	Coverage Δ
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp	`64.63% <ø> (ø)`
Core/include/Acts/TrackFitting/GsfOptions.hpp	`100.00% <ø> (ø)`
Core/include/Acts/TrackFitting/detail/GsfActor.hpp	`43.30% <0.00%> (-0.18%)`	:arrow_down:
.../include/Acts/TrackFitting/detail/GsfSmoothing.hpp	`35.23% <0.00%> (ø)`
Core/src/TrackFitting/GsfError.cpp	`0.00% <0.00%> (ø)`
Core/include/Acts/Seeding/SeedFilter.hpp	`0.00% <0.00%> (ø)`
Core/include/Acts/Seeding/SeedFilter.ipp	`0.00% <0.00%> (ø)`
Core/include/Acts/Seeding/SeedFinder.ipp	`0.00% <0.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Oct 20 '22 14:10 codecov[bot]

Maybe we should also quickly discuss this in tomorrows developer meeting, since it proposes changes to the definition of the public API / the versioning...

Oct 24 '22 11:10 benjaminhuth