Bryan Boreham comments

Results 997 comments of


                                            Bryan Boreham

promtool to report at least warning when scrape interval is greater than 4 minutes

Hello from the bug-scrub! This seems like a good first issue, at least if the scope is kept simple.

promtool to report at least warning when scrape interval is greater than 4 minutes

As far as I can see you already got a review, and are disagreeing on the next step.

Benchmark Prometheus restart scenarios (for WAL + snapshot cost and timing)

Agreed with the basic idea, but doesn’t the current startup rebuild Prometheus? We need to separate those things to get proper timing.

Compactions cause the configured storage.tsdb.retention.size to be exceeded (and risk of running out of disk space)

Hi, it seems your detailed report has not received much attention over the past 16 months. I might suggest that you put a 2-line summary of what you are suggesting...

PromQL engine: Delay deletion of name label to the end of the query evaluation

/prombench main

PromQL engine: Delay deletion of name label to the end of the query evaluation

/prombench cancel

PromQL engine: Delay deletion of name label to the end of the query evaluation

Should #10921 be closed?

Feature/aliyun ecs discovery

@KeyOfSpectator please can you say something about how this code will be maintained for years into the future.

Cumulative data points should set `StartTimeUnixNano` per timeseries

Is this really a specification issue? I read the spec as saying that implementations should set StartTime to match when the unbroken series of data points started. To me this...

Cumulative data points should set `StartTimeUnixNano` per timeseries

I am referring to this text in the [spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/data-model.md#temporality): > The second, optional timestamp is used to indicate when a sequence of points is unbroken, and is referred to as...