Bryan Boreham

Results 937 comments of Bryan Boreham
trafficstars

Hello from the bug-scrub! Since #16716 is merged we will close this. Please reopen and clarify what is left to do here if necessary.

Closing as no response since April. Happy to re-open if you do come back.

Hello from the bug-scrub! Looks like nobody had an opinion to share here. Given that the code today must embody a choice, could we just document that as the answer...

Are they Resource attributes? See #14200. Likely duplicate of #13192.

To illustrate, the Prometheus config goes in an `otlp` section at top level, and might look like this: ``` global: scrape_interval: 15s scrape_timeout: 15s otlp: promote_resource_attributes: ["env", "service.name"] storage: tsdb:...

Thanks for moving this issue to where the file is located. I will note this seems like the wrong place for it to be located - it relates to the...

Seems to have happened again, or quite similar: https://github.com/prometheus/prometheus/actions/runs/17074711857/job/48412873193 ``` 2025/08/19 15:47:07 http: TLS handshake error from 127.0.0.1:59596: read tcp 127.0.0.1:38973->127.0.0.1:59596: use of closed network connection --- FAIL: TestConvertClassicHistogramsToNHCB (3.83s)...

Ok but my recommendation remains the same.

> I have replaced some of the existing metrics with new ones from PromBench, such as: How many of those did you count?

I trimmed down the newly-added queries a bit: * Slow down arithmetic_operation and logic_operator. * Took out a few queries to avoid overloading the server. * Stop querying `_bucket` series...