test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Add additional PromQL operators to synthetic load

Open kushalShukla-web opened this issue 1 year ago • 4 comments

This PR enhances the synthetic load generation by incorporating additional PromQL operators in the 6_loadgen.yaml file:

  • Added binary arithmetic operators (joins) to cover more complex query types.
  • Included logical operators (and, or, unless) for better query testing coverage.
  • Added topk function to test query performance with ranked results.

kushalShukla-web avatar Sep 18 '24 17:09 kushalShukla-web

Solves #705

kushalShukla-web avatar Sep 19 '24 05:09 kushalShukla-web

Hi, I commented on a few, but they are all likely problemmatic. I recommend you change tack to use metrics exposed by the fake webserver, since there are a lot of them and prombench can control them.

Actually i have tested this on one of the Pull Request where the prombench was running.

kushalShukla-web avatar Sep 19 '24 18:09 kushalShukla-web

Ok but my recommendation remains the same.

bboreham avatar Sep 19 '24 19:09 bboreham

I have replaced some of the existing metrics with new ones from PromBench, such as:

How many of those did you count?

bboreham avatar Sep 24 '24 19:09 bboreham

Hi @bboreham all the queries having value above 2000 , and codelabz metric is having 52000 different variations .

kushalShukla-web avatar Oct 02 '24 13:10 kushalShukla-web

I trimmed down the newly-added queries a bit:

  • Slow down arithmetic_operation and logic_operator.
  • Took out a few queries to avoid overloading the server.
  • Stop querying _bucket series directly; those should be used by histogram_quantile or similar.
  • Use more realistic k parameters to topk.

I also trimmed down some pre-existing queries for balance, to retain about the same overall load on the server as before.

bboreham avatar Oct 20 '24 17:10 bboreham