Bartosz Blimke

Results 218 comments of Bartosz Blimke

@pboling HTTP response body is never a hash (there is no Hash content type). Your ruby HTTP client most likely does the response body parsing for you and converts is...

perhaps `WebMock::RackResponse#session` should return that default_session instead of returning `{}` ?

@eatwithforks thank you for submitting this issue. What is the suggested behaviour in your opinion for handling incorrect url's in stub_request?

@saty9 It's not something supported by WebMock, though possibly it will work with RSpec's hash_including. E.g body: hash_including(urls: [....])

@thatsmydoing thank you for reminding me of that. @lucasuyezu thank you for the issue and the PR. the branch was already deleted, therefore it wasn't possible to merge the PR...

@mileslane WebMock doesn't know anything about Faraday. I suspect the error is raised somewhere else but is re-raised by WebMock.

@kepstin this has been an issue with webmock since always. It's worth another review in http client adapters though.

@bestwebua no plans. sorry. Do you have any specific example that you can share?

@bestwebua I think adding `normalized_params` options, will be unnecessary complication and in most cases, people who need it, will use it by default, therefore it would make more sense to...

@bestwebua the thing is that it's also request params are being normalized, not just stubbed url params.