Bartosz Blimke comments

Results 218 comments of


                                            Bartosz Blimke

HTTP instrumentation not fully working

Thanks @austinthecoder . I have checked and I indeed WebMock don't support instrumentation offered by http.rb yet.

HTTP instrumentation not fully working

@austinthecoder many http library features need to be implemented in WebMock, and it's likely that support for HTTP.use has been added after the adapter for WebMock has been implemented, that's...

Return effective_url as string (without port details)

Thank you @tbrammar. Looks good but I believe only the default port should be omitted?

Nested hash_including not working properly along with RSpec

@jefgarzon it's only when using nested hash_including right? I don't think nested hash_including has every been tested in WebMock

Nested hash_including not working properly along with RSpec

WebMock's version of hash_including has ben developed to cover hash_including in other environments than Rspec. When RSpec is used, default RSpec's hash_including is supposed to be used. I guess the...

disable_net_connect `:allow` encoding underscore to %5F

Thank you for submitting this @x2es

net_http_connect_on_start: true does not correctly stub out URLs if it cannot be resolved by the DNS

> I expect mocked URL's to not actually try to HTTP connect when net_http_connect_on_start is enabled, similar to the behavior when net_http_connect_on_start is disabled. By enabling `net_http_connect_on_start` , you are...

Not support symbol status code

@4geru do you mean allowing for `stub_request(:get, url).to_return(status: :ok, body: 'response')` ? Would it make much difference?

WebMock does not support matching body for multipart/form-data

No there isn't. It's not easy to fix (that's why it hasn't been fixed yet :). Direct body matching won't work as body parts boundaries change on each requested. The...

WebMock does not support matching body for multipart/form-data

@chadcf matching multipart body was never supported and never worked. The error messages were unclear so the assertion has been added to 2.x recently, which raises an error on an...