Bartosz Blimke comments

Results 218 comments of


                                            Bartosz Blimke

Force encoding to utf-8 breaks multipart file data in ruby 2.0

Can you provide a spec or sample code please?

Force encoding to utf-8 breaks multipart file data in ruby 2.0

Thanks. This is due to WebMock incorrectly trying to parse multipart body as url encoded body here https://github.com/bblimke/webmock/blob/master/lib/webmock/request_pattern.rb#L204 Maybe it should return raw body if there is an exception parsing....

Force encoding to utf-8 breaks multipart file data in ruby 2.0

Thanks for clarifying the RestClient params intention. It may not be so trivial to add multipart support to WebMock, but returning raw body in case url parser fails should be...

Force encoding to utf-8 breaks multipart file data in ruby 2.0

@jimherz Thank you for suggesting this idea. The problem is that the issue is not related to multipart only. It's related to WebMock behaviour, when a request stub is created...

Force encoding to utf-8 breaks multipart file data in ruby 2.0

@eric-hawkins no update :( I'm happy to accept a pull request, but I don't have too much time to work on WebMock now.

Stub request to return an Array within headers when using em-http-request

@matheussilvasantos if some adapters don't join it, it's only because http clients do it later. How would you send a collection as http header? Header names and values are just...

Stub request to return an Array within headers when using em-http-request

Perhaps the conversion to string is in the wrong place.

Proposal: Show request body diff to narrow test output

@Adrian1707 I think it's a fine case for an issue. Thank you for the blogpost, which clearly describes the problem and the solution. It would be great to have support...

add expect_request to mirror mocha api

@grosser thank you for opening this issue. WebMock follows arrange-act-assert pattern e.g used by https://site.mockito.org instead of expect-run-verify, used by RSpec or Mocha. The main purpose was to make mock...

split header values on newlines - as created by Rack::Utils

@brushbox The error "header field value cannot include CR/LF" comes from Net::HTTP. Do you know why there is an error when using WebMock and not when executing requests without WebMock?...