Bartosz Blimke comments

Results 218 comments of


                                            Bartosz Blimke

Live requests being made when running specs (> v3.1.1)

Thank you @TimothyClayton Ok, then it must be the change in commit `d9af3a5` The effects of that change very much depend on the project setup, theforefore it would be very...

Cannot stub `OPTIONS *` requests

Thank you for raising. Indeed, it expects a valid path path string and does not accept `*`. Do you know if `*`, single character, is the only exception?

Checking order stubs were called

I don't see a way to extract that information from WebMock, but you can use callbacks https://github.com/bblimke/webmock#request-callbacks and perform your own checks for order.

[Proposal] Create matcher to match request params and headers

@leomao10 thank you for submitting this issue. Why not to add the params to the request stub? I like how your proposed code is readable. My concern would be not...

undefined method `reset_executed_requests!' for WebMock:Module in rspec test

@wgordon17 you're right. thank you for pointing that out!

undefined method `reset_executed_requests!' for WebMock:Module in rspec test

That is not expected. It's a bug.

Failures shouldn't recommend mocking the "User-Agent" header.

:+1: good idea. Please do submit a pull request.

Start connection in `Net::HTTP` adapter for mocked requests

@ojab I'm sorry for the delay. Is that related specifically to Sentry which checks for `Net::HTTP.started?` . My concern is that in all other cases it will unnecessarily call request...

net_connect_explicit_allowed? should not be case-sensitive

Thank you @dmolesUC3! If you would you like to provide a PR with the fix, you are very welcome.

Include documentation RegEx hash_including matcher

@ChrisBr this only works if we are inside RSpec. WebMock has own limited implementation of hash_including in case hash_including is not already available. Perhaps it's better to mention that in...