Bartosz Blimke comments

Results 218 comments of


                                            Bartosz Blimke

Assert that a request was made via a proxy server

@mikebaldry thank you for your suggestion. It sounds like a useful feature. It will have to wait though, unless someone submits a pull request with support for proxy.

Assert that a request was made via a proxy server

I'm not aware of anyone working or planning to work on adding support for that.

`uri` method on mocked `Net::HTTPOK` incorrectly returns nil

@abevoelker thank you for reporting that. I'd need to investigate more to find out what the root cause is, unless someone investigates that before me.

Proposal to alias `enable_net_connect!` and `disallow_net_connect!`

@owyongsk makes sense. Do you fancy a pull request?

`hash_including` matcher breaks `WebMock::Util::Headers.normalize_headers`

@cosmicbuffalo hash_including doesn't work for headers, but matching headers behaves like hash_including by default.

stub_request with "times" should be unregistered after executed

I agree it is not intuitive. It's not as much desired, as just not taken into account. WebMock will keep returning last declared response after all other declared responses have...

stub_request with "times" should be unregistered after executed

@glebsts webmock will keep returning the last declared response. `times` in response chain only makes sense if there are additional responses declared further down the chain. Nothing has changed in...

IT'S BEEN A YEAR SINCE THE LAST RELEASE ON RUBYGEMS

Nothing happened to me apart from being busy and not having enough time for opensource :/ Just releasing new version.

Add support for net-http2 backend

@singpolyma-shopify Thank you! Do you plan to add specs and cover real requests?

Add support for net-http2 backend

@singpolyma-shopify right, that would probably require a new set of tests.