Bartosz Blimke

Results 218 comments of Bartosz Blimke

@collimarco the difference between 3.2.0 and 3.1.1 just affect curb and enabling WebMock in Rspec. Net::Http adapter hasn't been touched. Does the problem exist when running Rspec or can you...

Would you mind checking if the previous commit, a6579a works fine?

There is no regex matcher therefore it can't work. It's just a hash with regex value. You can consider using a block to match request: https://github.com/bblimke/webmock#matching-requests-against-provided-block Or you can match...

Could you please send the example that is not working?

@thoraxe yes, this is intended. when WebMock is disabled, disable_net_connect doesn't have any effect on WebMock since WebMock doesn't do anything.

@thoraxe enabling/disabling WebMock and enabling/disabling net connections are orthogonal concerns. `enable!` and `disable!` make WebMock to start interacting or stop interacting with http client adapters. `disable_net_connect!` is a configuration which...

Thank you @taki Yes, that sounds like much nicer code to read 👍 As long as people get a clear error message in case they provide non String query option...

> My sense with a majority of Rails apps is that this is not the case I agree though please take into account that often Rails apps are only clients...

@rmichelli any chance you have some old version of test-unit gem loaded?

@rokkit that definitely doesn't look right. can you please provide an a code sample or spec example?