Basil Crow
Basil Crow
Right, this PR is really two logical portions, a portion adding new infrastructure, and another portion to apply the formatting onto the rest of the codebase. So for a backport...
I think Wadeck's comment about the ugly `else` statement could be addresesd by turning on ESLint's [`curly`](https://eslint.org/docs/latest/rules/curly) check in `all` mode (require braces for all `if`/`else` statements). This could be...
From [the Spotless documentation](https://github.com/diffplug/spotless/tree/339b3555787ca3697cc196e476c164bbe251ebac/plugin-maven): > Prettier is based on NodeJS, so to use it, a working NodeJS installation (especially npm) is required on the host running spotless. Spotless will try...
BTW I don't care how many PRs we use, but I feel strongly that we have at least two commits after all is integrated (one for the manual changes to...
The intended consumer https://github.com/jenkinsci/role-strategy-plugin/pull/179 has not yet been reviewed. That needs to happen before this core PR can be considered.
Confirmed that this fixes [JENKINS-69257](https://issues.jenkins.io/browse/JENKINS-69257) as follows: - Checked out `jenkins-2.320` - Confirmed that `git grep jenkins-table__link` returned no results - Compiled the code - Built a freestyle project and...
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the [merge process documentation](https://github.com/jenkinsci/jenkins/blob/master/docs/MAINTAINERS.adoc#merge-process) for more information...
Manually verified as of commit 93f69b292e
On July 13, 2022, two members of the Jenkins core team approved this PR. At the time of this writing on August 26, 2022, neither of those two members of...
The above review expresses a generally positive assessment of this change, tempered by the cautionary concern that this area has been the source of number of regressions in the past...