jenkins icon indicating copy to clipboard operation
jenkins copied to clipboard

[JENKINS-69145] bouncing build number element on mouse hover

Open frankie139506 opened this issue 3 years ago • 8 comments

See JENKINS-69145.

Proposed changelog entries

  • Fix bouncing build number element on mouse hover.

Proposed upgrade guidelines

N/A

Submitter checklist

  • [X] (If applicable) Jira issue is well described
  • [X] Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • [X] Appropriate autotests or explanation to why this change has no tests
  • [ ] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • [ ] New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • [ ] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • [ ] There are at least 2 approvals for the pull request and no outstanding requests for change
  • [ ] Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • [ ] Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • [ ] Proper changelog labels are set so that the changelog can be generated automatically
  • [ ] If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

frankie139506 avatar Jul 27 '22 19:07 frankie139506

Would this also take care of JENKINS-68160?

daniel-beck avatar Jul 29 '22 20:07 daniel-beck

Would this also take care of JENKINS-68160?

Yes, it also fix JENKINS-68160's problem.

frankie139506 avatar Jul 30 '22 01:07 frankie139506

With this change it is no longer possible to access the context menu dropdown of model-links. The hover state collapses before I can move the pointer to the chevron.

Screen.Recording.2022-07-30.at.10.18.27.mov

@daniel-beck In my test, it is normal, This is my demo. gif2

frankie139506 avatar Jul 30 '22 09:07 frankie139506

Move your mouse pointer more slowly. I found it sometimes works when moving the pointer fairly quickly.

Otherwise, I used Firefox 103 and most pages have some level of zoom >100%, probably was the case here too.

daniel-beck avatar Jul 30 '22 20:07 daniel-beck

Move your mouse pointer more slowly. I found it sometimes works when moving the pointer fairly quickly.

Otherwise, I used Firefox 103 and most pages have some level of zoom >100%, probably was the case here too.

Thanks for your suggestion. I have make some change, please take a look. gif2

frankie139506 avatar Jul 31 '22 01:07 frankie139506

The latest state of this no longer causes the issue when slowly moving the mouse pointer 👍

Not approving as of now as I've only inconsistently been able to reproduce JENKINS-68160. Requesting @jtnord as the reporter of JENKINS-69145.

daniel-beck avatar Aug 01 '22 10:08 daniel-beck

I can verify that JENKINS-69145 is indeed fixed, thankyou!

jtnord avatar Aug 01 '22 13:08 jtnord

Could I get a reviewer for this PR?

frankie139506 avatar Aug 05 '22 01:08 frankie139506

@janfaracik Do you mind taking a look and could clarify Daniel's open concerns?

NotMyFault avatar Aug 23 '22 19:08 NotMyFault

Manually verified as of commit 93f69b292e

basil avatar Sep 02 '22 18:09 basil