Basil Crow

Results 400 comments of Basil Crow

> Are you using the default [`GIT_ATTRIBUTES` line endings policy](https://github.com/diffplug/spotless/tree/main/plugin-maven#line-endings-and-encodings-invisible-stuff), or are you setting it to `PLATFORM_NATIVE` manually? The default.

> Spotless always passes unix line endings to each step, but it doesn't care which line endings it gets back An excellent example of [Postel's law](https://en.wikipedia.org/wiki/Robustness_principle): > Be conservative in...

Great! I am happy to name it `importOrderGoogleJavaFormat(String version)`, although in that case would you want it to not remove unused imports? If so, I suppose the user could specify...

> @basil can you help me get the right people to review this PR? Sorry to @ mention you directly, but there are no OWNERS or CONTRIB for this repo...

Hi @KirkMartinez, sorry for the delay in reviewing this. I just took a look now, and while overall the change looks fine, I wanted to suggest a possible alternative. The...

Hey @timsutton, thanks for the PR! The implementation looks good, but I need to think a little bit more about the API. I need to make sure we're designing an...

Rebuilding to hopefully get a clean test run.