Basil Crow

Results 400 comments of Basil Crow

Wow, this looks great! I am very pleased with the result and I think this is a huge step forward. I only have one piece of optional non-blocking feedback for...

> it really needs you to know that the error is due to the line endings to begin with. The output from maven is Failed to run task: 'yarn lint:ci'...

With one -0 vote and no positive votes, I am marking this as proposed for close.

With one -0 vote and no positive votes in over 1 month, I am closing this PR.

While I normally include dependency updates in the changelog, this release felt so minor from a user perspective that I decided to skip it. Happy to revisit that decision if...

Right, we think this is a great idea, but like https://github.com/jenkinsci/jenkins/pull/4736, it needs corresponding changes to our Pipeline jobs to invoke `./mvnw` rather than `mvn`.

This pull request is off to a promising start but requires additional effort to reach completion: effort that appears to have been abandoned. Since this pull request has remained incomplete...

> If it remains inactive for several more weeks, I will label it as `proposed-for-close` in order to maintain an orderly PR queue and close the PR approximately one week...

> Apologize, I don't know what I need to change to. I, too, share this contributor's confusion about what the action items are in order to move forward with this...

> Such changes have a significant cost for the security team when we are working on backports (as well as for the release manager). Did we not have a similar...