Basil Crow

Results 420 comments of Basil Crow

@mdorotich-swi If the changes from https://github.com/jenkinsci/scm-sync-configuration-plugin/pull/74 work, you can consider [adopting the plugin](https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/) to merge and release the PR. The "[Contributing to Open Source](https://docs.google.com/document/d/1PKYIpPlRVGsBqrz0Ob1Cv3cefOZ5j2xtGZdWs27kLuw/edit#heading=h.hvd0nm6pz5o4)" workshop from DevOps World 2021 is...

> just I could see an argument for _also_ implementing that _by default_ under the general principle of not leaking resources. But I think this PR has independent value. Let...

> Why not just implement `ItemListener.onDeleted` so `workspace/xxx@libs/` gets deleted when `jobs/xxx/` is deleted? Done in #115.

@mohammad-eghlima Based on my analysis above, this is a problem with `Log4jHotPatch`, not a problem with Jenkins, which is [not vulnerable to CVE-2021-44228 in the first place](https://www.jenkins.io/blog/2021/12/10/log4j2-rce-CVE-2021-44228/). So if you...

We worked around this problem in Jenkins 2.358 by moving our main class into the `executable` package namespace so that `Log4jHotPatch` doesn't trip over it, but this remains a bug...

I am not a maintainer of this plugin.

A clean CI run of this PR will depend on removing 2.276 from the `Jenkinsfile`, which I do not have commit access to do.

I still want to get this done eventually, but I need to do some further work in `jenkinsci/bom` to prepare for this.