jenkins
jenkins copied to clipboard
[JENKINS-68602] parent name for ProjectNamingStrategy
add a new method checkName(parentName, name) to the ProjectNamingStrategy so that it is possible to check the full name of an item.
See JENKINS-68602.
Proposed changelog entries
- enable ProjectNamingStrategy to check the full name of a new item
Proposed upgrade guidelines
N/A
Submitter checklist
- [ ] (If applicable) Jira issue is well described
- [ ] Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
- Fill-in the
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
- Fill-in the
- [ ] Appropriate autotests or explanation to why this change has no tests
- [ ] New public classes, fields, and methods are annotated with
@Restricted
or have@since TODO
Javadoc, as appropriate. - [ ] For dependency updates: links to external changelogs and, if possible, full diffs
Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as ready-for-merge
:
- [ ] There are at least 2 approvals for the pull request and no outstanding requests for change
- [ ] Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
- [ ] Changelog entries in the PR title and/or
Proposed changelog entries
are accurate, human-readable, and in the imperative mood - [ ] Proper changelog labels are set so that the changelog can be generated automatically
- [ ] If the change needs additional upgrade steps from users,
upgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example) - [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as
lts-candidate
to be considered (see query).
The intended consumer https://github.com/jenkinsci/role-strategy-plugin/pull/179 has not yet been reviewed. That needs to happen before this core PR can be considered.
The intended consumer jenkinsci/role-strategy-plugin#179 has not yet been reviewed. That needs to happen before this core PR can be considered.
The core PR may ends up stalled, there are currently no active maintainers of the role strategy plugin.
I removed the stalled
label, the plugin has been adopted by the PR author, who maintains it now.
The downstream PR has been merged by now.
Role strategy is already implementing the API
Just the @Override
annotation is not there yet
https://github.com/jenkinsci/role-strategy-plugin/blob/master/src/main/java/org/jenkinsci/plugins/rolestrategy/RoleBasedProjectNamingStrategy.java#L72
The workaround mentioned is for the a case when the old method is called.