Asger Nyman Christiansen

Results 117 comments of Asger Nyman Christiansen

Aha, so you wanted the dependency updated, that makes sense 👍 Feel free to make a PR if you have the time, I don't have a lot of time at...

> Sorry, I wasn't exactly sure if it was caused by version mismatch specifically so I made the issue sound more general, if you get what I mean. No problem...

Yes, that is definitely within scope 👍

> Thanks. I've replied to some of the comments. The other comments, I don't remember, I'll check again the reason for those changes. Perfect 👌 > > * We can...

That sounds weird, I don't assume that there's any nodes. Also, I just use another library called [gltf](https://crates.io/crates/gltf) for loading gltf files and it also seems like they don't assume...

I think it looks really good. Since I was so slow responding, I resolved the merge conflict and merged the changes. If you think there's more changes needed, feel free...

@thatcomputerguy0101 While looking at your changes, I realised that the whole control setup is a bit over engineered. Therefore, I tried to remove the `CameraControl` and the `CameraAction` in https://github.com/asny/three-d/pull/507....