ashnashahgrover
ashnashahgrover
## Commit to be reviewed --- docs(devcontainer): add trivy and its VSCode Extension Primary Changes ---------------- 1) updated trivy version in the .devcontainer file and included trivy vs-code extension 2)...
### Commit to be reviewed --- fix(test-tooling): use of hardcoded password ``` Primary Changes ---------------- 1. BREAKING CHANGE: "password" is now a mandatory parameter of the newEthPersonalAccount function defined in...
### Commit to be reviewed --- feat(iroha-connector): add prometheus exporter to the plugin ``` Primary Changes ---------------- 1. Added Prometheus Exporter to Iroha ledger plugin 2. Added Prometheus Metrics tracker...
## **Commit** to be reviewed test(ethereum): refactor jest test negative test cases ``` Primary Changes --------------- 1. Refactored negative test case exception assertions for cactus-plugin-ledger-connector-ethereum. Removed try-catch blocks, replaced with...
## **Commit** to be reviewed test: refactor jest test negative test cases - phase 1 ``` Primary Changes --------------- 1. Refactored all remaining negative test case exception assertions under cacti/packages...
## **Commit** to be reviewed test: fix all broken validations in packages folder ``` Primary Changes --------------- 1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too...
## **Commit** to be reviewed test(ethereum): fix broken validations in tests ``` Primary Changes --------------- 1. Added code to deployContract in plugin-ledger-connector-ethereum.ts that checks if any unexpected arguments are present,...
**Describe the bug** The deployContract function in cactus-plugin-ledger-connector-ethereum takes DeployContractV1Request as an argument, which already declares additional properties as forbidden in the Open API spec as can be seen [here](https://github.com/hyperledger/cacti/blob/957da7c3e1d80068391485a825ba6bb1e68333ac/packages/cactus-plugin-ledger-connector-ethereum/src/main/json/openapi.json#L435):...
**Describe the bug** Multiple tests are failing in cactus-plugin-ledger-connector-ethereum/src/test/typescript/integration including: - _geth-contract-deploy-and-invoke-using-json-object-v1.test.ts_: test("deployContract with additional parameters should fail") - _geth-contract-deploy-and-invoke-using-keychain-v1.test.ts_: test("deployContract with additional parameters should fail") - _geth-invoke-web3-method-v1.test.ts_: test("invokeRawWeb3EthMethod with...
Refactor all the negative test case exception assertions for cactus-plugin-ledger-connector-ethereum so that they do not use try-catch blocks but instead declare the requirements through Jest's (and jest-extended's) own API. The...