cacti icon indicating copy to clipboard operation
cacti copied to clipboard

feat(iroha-connector): add prometheus exporter to the plugin

Open ashnashahgrover opened this issue 1 year ago • 2 comments

Commit to be reviewed


feat(iroha-connector): add prometheus exporter to the plugin  

Primary Changes
----------------
1. Added Prometheus Exporter to Iroha ledger plugin
2. Added Prometheus Metrics tracker to relevant iroha tests.

Fixes #1260

Pull Request Requirements

  • [ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • [ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • [ ] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • [ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • [ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

ashnashahgrover avatar Aug 05 '24 22:08 ashnashahgrover

@jagpreetsinghsasan Have addressed all requested changes.

ashnashahgrover avatar Aug 06 '24 15:08 ashnashahgrover

@ashnashahgrover LGTM with comments (mostly just nit-picks)

Have addressed all the requests.

ashnashahgrover avatar Aug 11 '24 22:08 ashnashahgrover

Currently this one is stuck because of a pending change request from @jagpreetsinghsasan

@ashnashahgrover In case you didn't re-request review from @jagpreetsinghsasan , please do that. @jagpreetsinghsasan If there was a re-request review then please re-review when you get the chance so that we can move this along.

I'm not sure either way where did this one get stuck, but either which way let's get in moving!

petermetz avatar Oct 03 '24 00:10 petermetz

Yes, I think it got stuck because of my non-approval due to multiple workflow failures. LGTM

TheJagpreet avatar Oct 03 '24 03:10 TheJagpreet

Closing for now due to inactivity. We can reopen at is anytime in the future as needed.

petermetz avatar Oct 14 '24 22:10 petermetz