ashnashahgrover
ashnashahgrover
Please assign me.
Working on this
> "Using the Test Ledgers" and in there we link to some of my "favorite" test cases where the code is relatively clean/easier to read. Can you list the test...
> @ashnashahgrover Please fix the lint check and then we are good to merge This is done @petermetz
This issue is a dependency of https://github.com/hyperledger/cacti/issues/3475
> Did you verify if the test cases requiring this piece of code clearly specifies `test` as the password? @jagpreetsinghsasan There are no test cases in the repo using this...
> @ashnashahgrover Please fix the commit lint issues and document that it's a breaking change in the commit message (which then will get recognized by the change log and put...
> @ashnashahgrover The breaking change is that you made a previously optional parameter of the function mandatory. It doesn't refer to line breaks in text (although those can be important...
@jagpreetsinghsasan Have addressed all requested changes.
> @ashnashahgrover LGTM with comments (mostly just nit-picks) Have addressed all the requests.